[18.0][MIG] hr_job_category: Migration to 18.0 #1415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
[UPD] Update hr_job_category.pot [UPD] README.rst Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (4 of 4 strings) Translation: hr-14.0/hr-14.0-hr_job_category Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_job_category/pt_BR/ Translated using Weblate (German) Currently translated at 100.0% (4 of 4 strings) Translation: hr-14.0/hr-14.0-hr_job_category Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_job_category/de/ [UPD] Update hr_job_category.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-14.0/hr-14.0-hr_job_category Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_job_category/
When updating the hr.contract we shouldn't remove already existing tags When you update the contract, you dont remove tags that are manually added
[BOT] post-merge updates
Currently translated at 100.0% (4 of 4 strings) Translation: hr-17.0/hr-17.0-hr_job_category Translate-URL: https://translation.odoo-community.org/projects/hr-17-0/hr-17-0-hr_job_category/it/
BhaveshHeliconia
force-pushed
the
18.0-mig-hr_job_category
branch
from
c4479e3 to
4bf96b3
Compare
luisDIXMIT
reviewed
May 5, 2025
| employee.write({"category_ids": tags_to_add}) | ||
|
|
||
| @api.model_create_multi | ||
| def create(self, vals_list): |
There was a problem hiding this comment.
Since the create method in version 18 receives a list of vals as a parameter, it must be iterated to validate each record. Therefore, the method must be written as follows, otherwise it won't work.
Suggested change
| def create(self, vals_list): | |
| def create(self, vals_list): | |
| res = super().create(vals_list) | |
| for vals in vals_list: | |
| if "job_id" in vals: | |
| res._tag_employees(vals.get("job_id")) | |
| return res |
BhaveshHeliconia
force-pushed
the
18.0-mig-hr_job_category
branch
from
4bf96b3 to
65da7b4
Compare
|
@luisDIXMIT, Please Review.it's done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.